nsqd: diskqueue now takes AppLogFunc instead of Logger #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM after updates on the |
ploxiln
force-pushed
the
diskqueue_logf
branch
from
7316b7c to
dd11467
Compare
ploxiln
changed the title
|
updated but still waiting to update Godeps |
|
Just waiting on |
diskqueue support for log levels
ploxiln
force-pushed
the
diskqueue_logf
branch
from
dd11467 to
2ee959a
Compare
|
updated Godeps |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... so the diskqueue logging integrates with log levels.
The adapter function is needed because the LogLevel types are not defined in the same package, because
go-diskqueuecannot importnsq/internal/lg. If levels were just plain ints this would be cleaner.See nsqio/go-diskqueue#2 for companion PR. If that is merged I'll update the Godeps in this PR.
cc @mreiferson